Closed jbajwa closed 8 years ago
Investigating one of the testcase, int32mod-constant.js. So far I've got: Math.abs is not working as expected on s390x. Running this js snippet with d8 can reproduce the issue, moreover with snapshot off the issue is gone.
> out/s390x.release/d8 abs.js
-2147483648 // (should be 2147483648)
>cat abs.js
print(Math.abs(-2147483648))
Gets the absolute value of any other negative number correctly. Only fails for -2147483648 which is the min value for a signed int32. Only affects s390x sim builds with snapshot on.
https://codereview.chromium.org/2446113013 The issue was that the logic to detect INT_MIN in 64bit was incorrect.
82 testcases are failing on s390x (64bit) on sim build. The failure started after this CL https://codereview.chromium.org/2451973003
Some of the failures: