ibmruntimes / v8-zos

The official mirror of the V8 git repository
https://chromium.googlesource.com/v8/v8.git
Other
1 stars 1 forks source link

PPC64 [native]: testcase test-spaces/SizeOfInitialHeap failing #20

Closed jbajwa closed 8 years ago

jbajwa commented 8 years ago
> out/ppc64.release/cctest --random-seed=-795785457 test-spaces/SizeOfInitialHeap --nohard-abort --nodead-code-elimination --nofold-constants

stderr:
#
# Fatal error in ../test/cctest/heap/test-spaces.cc, line 520
# Check failed: (heap->paged_space(i)->CommittedMemory())<(kMaxInitialSizePerSpace).
#

==== C stack trace ===============================

    out/ppc64.release/cctest() [0x106339b4]
    out/ppc64.release/cctest() [0x1062ce4c]
    out/ppc64.release/cctest() [0x102dec58]
    out/ppc64.release/cctest() [0x1025e604]
    out/ppc64.release/cctest() [0x100e84e4]
    /lib64/power8/libc.so.6(+0x24580) [0x3fffac874580]
    /lib64/power8/libc.so.6(__libc_start_main+0xc4) [0x3fffac874774]

Its PPC64 specific so it might be related to the OS page size being 64K.

jbajwa commented 8 years ago

git bisect just completed. First bad commit is https://codereview.chromium.org/2438683005 Quick look doesn't point to why it would fail on ppc64 (related to OS page size). Going to investigate further.

ytzi commented 8 years ago

Debug build error message:

#
# Fatal error in ../test/cctest/heap/test-spaces.cc, line 520
# Check failed: heap->paged_space(i)->CommittedMemory() < kMaxInitialSizePerSpace (2424832 vs. 2097152).
#

The error is consistant (the figures are the same.)

ytzi commented 8 years ago

The page size being 64K caused the system unable to free some small amount of memory in order to free up the memory so that the code space usage is below 2MB.

ytzi commented 8 years ago

In Debug mode it is supposed to skip check for the code space but the test did not skip that. Investigating.

jbajwa commented 8 years ago

@zyt33 That might not be related to this issue, lets upstream the fix for this testcase and we can create a separate CL for the debug mode issue.

jbajwa commented 8 years ago

also I'm guessing that debug mode issue is not arch-specific?

jbajwa commented 8 years ago

https://codereview.chromium.org/2523293002/ (waiting to get reviewed) Thanks @zyt33 !

jbajwa commented 8 years ago

fix upstreamed to master and backported to 5.6 (https://codereview.chromium.org/2530233002/)