search

ibmruntimes / v8-zos

The official mirror of the V8 git repository
https://chromium.googlesource.com/v8/v8.git
Other
1 stars 1 forks source link

PPC: Debug build failing #26

Closed jbajwa closed 7 years ago

jbajwa commented 7 years ago 
> make ppc64.debug
...
...
LINK(target) /local/jbajwa/google_v8/v8/out/ppc64.debug/mksnapshot
  ACTION src_v8_gyp_v8_external_snapshot_target_run_mksnapshot__external_ /local/jbajwa/google_v8/v8/out/ppc64.debug/snapshot_blob.bin
abort: The function_data field should be a BytecodeArray on interpreter entry
/bin/sh: line 1: 90370 Segmentation fault      (core dumped) "/local/jbajwa/google_v8/v8/out/ppc64.debug/mksnapshot" --random-seed 314159265 --startup_blob "/local/jbajwa/google_v8/v8/out/ppc64.debug/snapshot_blob.bin" ""
make[1]: *** [/local/jbajwa/google_v8/v8/out/ppc64.debug/snapshot_blob.bin] Error 139
make[1]: Leaving directory `/local/jbajwa/google_v8/v8/out'
make: *** [ppc64.debug] Error 2

Started failing after the debug_code flag was enable for debug builds https://codereview.chromium.org/2528913002

The following assert is failing:

>src/builtins/ppc/builtins-ppc.cc
1050   if (FLAG_debug_code) {
1051     __ TestIfSmi(kInterpreterBytecodeArrayRegister, r0);
1052     __ Assert(ne, kFunctionDataShouldBeBytecodeArrayOnInterpreterEntry);

So somehow kInterpreterBytecodeArrayRegister ends up being smi.

jbajwa commented 7 years ago

fix upstreamed https://codereview.chromium.org/2560473003