search

ibmruntimes / v8-zos

The official mirror of the V8 git repository
https://chromium.googlesource.com/v8/v8.git
Other
1 stars 1 forks source link

PPC/S390: ES6-Module test got different hash value than expected output on native #43

Closed sampsongao closed 7 years ago

sampsongao commented 7 years ago 
./out/ppc.release/inspector-test --random-seed=-718045194 ./test/inspector/protocol-test.js 
./test/inspector/runtime/es6-module.js

./out/s390.release/inspector-test --random-seed=-718045194 ./test/inspector/protocol-test.js 
./test/inspector/runtime/es6-module.js

The hypothesis now is that the endianness is affecting the hashing algorithm.

sampsongao commented 7 years ago

Hash function found at ./src/inspector/v8-debugger-script.cc Line 29

sampsongao commented 7 years ago

https://codereview.chromium.org/2787713003

sampsongao commented 7 years ago

Landed as https://chromium.googlesource.com/v8/v8/+/de74e1ac8495305718d5a6ddbe7a4702eadeead0