ibmruntimes / v8ppc

Port of Google V8 javascript engine to PowerPC®
Other
94 stars 19 forks source link

Fix profile code (and possibly others) that call C functions to use "correct" macro #87

Open andrewlow opened 11 years ago

andrewlow commented 11 years ago

Looking at change a001954099d8429f3bc0d14ec0e2e91f75f59087

It struck me that the code is making use of the Call() macro, but in fact it is calling an external C function. we may need to validate that it is always calling an external C function

As we work towards a more sane implementation of the ABI on Power, we may want to redirect some of these from Call() to CallCFunction().

mtbrandy commented 11 years ago

RegExpCEntryStub::Generate is another location to consider changing to use CallCFunction.