search

ibmruntimes / yieldable-json

Asynchronous JSON parser and stringify APIs that make use of generator patterns
Other
145 stars 22 forks source link

src: descope global variables #15

Closed yathamravali closed 4 years ago

yathamravali commented 5 years ago

Several variables kept global were causing APIs to fail when reentered the scope of variables are shared between each invocation is global. Fix that by making the scope of those variables local.

Add two unit tests to validate this scenario

Refs: #8

simllll commented 4 years ago

What's the current situation with this? It's a while since the last activity?

gireeshpunathil commented 4 years ago

thanks for reminding @simllll - this one fell through the cracks. Let me fast-track this.

gireeshpunathil commented 4 years ago

landed as 1dd596f6545f622870c83b56f50474be59a7b8eb

simllll commented 4 years ago

Great thanks for the quick reply, is there any ETA for an upcoming release?

gireeshpunathil commented 4 years ago

@simllll - thanks for checking. I was planning to cover the couple of outstanding PRs as well, but can reconsider releasing one in the interim. Do you have a critical need on it? A one liner statement please!

simllll commented 4 years ago

No hurry, we actually ran into another issue with yiedable-json, I will try to set up a little test for this.