ibnemahdi / owasp-esapi-java

Automatically exported from code.google.com/p/owasp-esapi-java
Other
0 stars 0 forks source link

password change is not saved #136

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Changing the password via the FileBasedAuthenticator
2. forget to call saveUsers()
3.

What is the expected output? What do you see instead?
When changing the password for a user, a call to saveUsers() is needed on the 
FileBasedAuthenticator or else a password change will not be saved for good.

Yet ESAPI.authenticator() returns an object with no such method, therefore a 
cast is necessary.

What version of the product are you using? On what operating system?
version build from latest source

Please provide any additional information below.
I would prefer that the changePassword method saves the users, like in the 
createUser method. Infact everytime the usermap is changed, we should save. 

Original issue reported on code.google.com by j...@cs.au.dk on 11 Aug 2010 at 4:09

GoogleCodeExporter commented 9 years ago
Agreed. We need this fixed before 2.0GA.

Original comment by manico.james@gmail.com on 2 Nov 2010 at 8:09

GoogleCodeExporter commented 9 years ago
Another one liner - probably easier to just patch yourself - patch attached 
however.

Original comment by jtmel...@gmail.com on 3 Nov 2010 at 3:39

Attachments:

GoogleCodeExporter commented 9 years ago
Committed change, and reran unit tests - passed.

Original comment by jtmel...@gmail.com on 4 Nov 2010 at 2:17