search

ibnishak / Timimi

Webextension to save Tiddlywiki
https://ibnishak.github.io/Timimi/
GNU Affero General Public License v3.0
206 stars 23 forks source link

implement injection of TWC saver for Chrome #48

Closed YakovL closed 4 years ago

YakovL commented 4 years ago

So here's my first approach to fixing saving of TWC in Chrome. Since I haven't succeeded in making local unpacked extension to work with Timimi backend yet (on Windows, see #44 for details), this is not fully tested and may need to be fixed further. Another thing to note is this change can be applied to Firefox extension as well so that the codebase is the same (haven't tested it yet though).

YakovL commented 4 years ago

another thing to note and probably to fix: in some places description says that Timimi is for TW5 while it's more for TW in general. For instance, this is written in readme that is show after installing both backends (for FF and for Chrome), presumably that's Timimi/installer/windows/readme.txt. Also Timimi/installer/windows/firefox-json/timimi.json and Timimi/installer/windows/chrome-json/timimi.json state "Native messaging host to save TW5", should be "Native messaging host to save TiddlyWiki" (or "TWC and TW5").

ibnishak commented 4 years ago

Congratulations @YakovL You did it.I tested in chrome and saving works.

Once I am done fixing a few unrelated bugs, it will be pushed to the chrome store. Great job!