Serious error with Timimi - Githubissues

ibnishak / Timimi

Webextension to save Tiddlywiki

https://ibnishak.github.io/Timimi/

GNU Affero General Public License v3.0

204 stars 20 forks source link

Serious error with Timimi #80

Closed AnthonyMuscio closed 2 years ago

AnthonyMuscio commented 2 years ago

@ibnishak I am hoping you could make a small fix to Timimi which has caused me some confusion a number of times, until I rediscover a bug in Timimi.

The Problem is if you use a url address with anything after the path eg URL?mode=edit

Providing URL#tiddlername is OK. and allows saving

I am testing this on other savers and will report if I observe any other cases of this.

I think all that needs to be done is to parse the URL and only use everything that occurs before the "?" as the filename/address

if "?" is in the URL
Please note I may have reported this earlier but could not locate it.
I believe this is necessary to adhere to standard URI protocols

Thanks in advance

ibnishak commented 2 years ago

This is not a timimi bug, but a tiddlywiki bug. URL parsing is done by the core and passed to timimi. Please notify in the Tiddlywiki repo.