nus-se-bot
commented
4 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Feature Flaw: Adding Person Functionality Not Optimal
While it is entirely plausible for two people to have the same name, it is also entirely unlikely for two people to have the same e-mail ID or phone number.
Although it is mentioned in the UG as Phone Numbers, Emails need not be unique, I do believe it to be a feature flaw as it is not intuitive and allows duplication of fields that shouldn't have it and vice versa.
[original: nus-cs2103-AY2324S2/pe-interim#5304] [original labels: type.FeatureFlaw severity.High]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thanks for raising this. This viewpoint is valid but not in the context of this application. Furthermore, this is intended and mentioned in the UG, it is not in scope of the product.
It may be a common practice at an organisation level for people to share the same email address and landline phone numbers
A valid NUS example may be the CS2103 Teaching Team itself. Whose cs2103@comp.nus.edu.sg email address access may be shared across multiple professors. If the professors would like to indicate that as the primary contact email, it is possible to do so.
The same applies to the the staff office where several tables may share the same phone line 6123 4567 and the staff would not like to indicate their personal numbers but the landline number instead.
Hence to accommodate for situations like this it is a better choice to allow for duplicate emails and phone numbers.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
I am able to add people who have different names but the same details. I think it is more likely for 2 different people to have different phone numbers and emails rather than names so this may be something to consider.