ibotty / golang-github-prometheus-node_exporter

MIT License
11 stars 6 forks source link

build v1.0 on fedora <32 and centos 7/8 #11

Open systemcrash opened 4 years ago

systemcrash commented 4 years ago

Released a few days ago.

ibotty commented 4 years ago

I have that on my todo-list. I will get to it in the next days.

ibotty commented 4 years ago

Too bad, as I expected it does not build because it needs a newer go.

https://github.com/prometheus/node_exporter/issues/1704

I am not sure how to resolve this. Worst-Case is downloading golang before building the rpm. I don't know whether I like that. Any other ideas?

ibotty commented 4 years ago

Well, it does work for fedora 32.

systemcrash commented 4 years ago

I am not sure how to resolve this. Worst-Case is downloading golang before building the rpm. I don't know whether I like that. Any other ideas?

¯\_(ツ)_/¯

Today I'm all out. Downloading pre-requisites, if not in the usual repos, seems like the only thing possible.

ibotty commented 4 years ago

I editorialized the issue to describe the problems left.

systemcrash commented 3 years ago

Weirdly, COS7 has golang 1.15 in EPEL, which should make compiling 1.0.x possible. COS8 is lacking on this front.

https://centos.pkgs.org/7/epel-x86_64/golang-1.15-1.el7.x86_64.rpm.html https://centos.pkgs.org/7/epel-testing-x86_64/golang-1.15.2-1.el7.x86_64.rpm.html

I gather you're not partial to using anything other than fedora for building.

ibotty commented 3 years ago

I don't know, I follow. On fedora building is great. The problem is building on CentOS. It's not possible to use the Fedora 32 package on CentOS7 though, because rpmlib(PayloadIsZstd) <= 5.4.18-1 is needed by golang-github-prometheus-node_exporter-1.0.1-1.fc32.x86_64. I am not entirely sure how to proceed when using koji.

mog01 commented 3 years ago

Sorry, I must be missing something, what's the blocker for updating the CentOS 7 package to version 1.x.x please? Thanks in advance!

ibotty commented 3 years ago

The problem is that centos is not shipping a go compiler recent enough. It would be a hack that is not so nice and I, personally, don't need it. I would favorably review a pull request though.