ibotty / golang-github-prometheus-node_exporter

MIT License
11 stars 6 forks source link

misleading README? #13

Open bfallik opened 4 years ago

bfallik commented 4 years ago

Hi,

Apologies if this isn't the right place to log my request. I followed the Contact button from copr.

The README at /etc/prometheus/node_exporter/text_collectors/ says This is a place for textfile collectors for node_exporter but that seems incorrect. According to /etc/sysconfig/node_exporter the node_exporter is passed --collector.textfile.directory /var/lib/node_exporter/textfile_collector on startup.

Any chance the packaging could be improved to either correct the README in /etc/prometheus to point the naive user (e.g. me) at /var/lib/node_exporter/... or else move the README under /var/lib/node_exporter/text_collectors and, ideally, not stop creating the unused /etc/prometheus/node_exporter/text_collectors/ directory.

$ dnf info golang-github-prometheus-node_exporter
Installed Packages
Name         : golang-github-prometheus-node_exporter
Version      : 1.0.1
Release      : 1.fc32
Architecture : x86_64
Size         : 23 M
Source       : golang-github-prometheus-node_exporter-1.0.1-1.fc32.src.rpm
Repository   : @System
From repo    : copr:copr.fedorainfracloud.org:ibotty:prometheus-exporters
Summary      : Exporter for machine metrics
URL          : https://github.com/prometheus/node_exporter
License      : ASL 2.0
Description  : Exporter for machine metrics

Thanks in advance.