search

ibotty / openshift-letsencrypt

MIT License
59 stars 31 forks source link

Fixed template name #11

Closed mguillem closed 7 years ago

mguillem commented 7 years ago

There is no letsencrypt-template.yaml file in the project

ibotty commented 7 years ago

have you tested the role assignement? AFAICT it won't work as is, because get_certificate will try to get the acme secret (which will fail when admin rights are not granted).

Of course, one could mount the secret in the pod (has to be added to the template) and remove that part.

ibotty commented 7 years ago

I forgot: thank you for contributing!

mguillem commented 7 years ago

This is the role assignment that works for me on two different openshift installations:

openshift v1.3.1 kubernetes v1.3.0+52492b4

openshift v3.4.1.2 kubernetes v1.4.0+776c994

Btw: great tool! Thanks. An appropriate error message if routes can't be retrieved due to missing rights would have helped in my case.

mguillem commented 7 years ago

Seems that my previous code was not really the right one. It worked but I don't understand why. This one makes sense to me and is working correctly:

oc policy add-role-to-user edit system:serviceaccount:`oc project -q`:letsencrypt