search

ibotty / openshift-letsencrypt

MIT License
59 stars 31 forks source link

Clusterrole updated #28

Open macmacs opened 7 years ago

macmacs commented 7 years ago

I added the clusterrole.yaml from openshift-acme.

It fixes #26.

ibotty commented 7 years ago

We don't need as many permissions. Can you test without endpoints, services, events, and most important: secrets?

macmacs commented 7 years ago

Removed endpoints, services, events and secrets.

Works!

ibotty commented 7 years ago

Looks good. Do you have a 1.5 cluster handy to test, whether the cluster role also works there? I could only test some time next week.

Also, I prefer if you could rebase the changes to one logical change, I.e. group the Readme changes and the cluster role change. Thank you!

macmacs commented 7 years ago

At the moment, I don't have a 1.5 cluster at hand. Sorry.

And I will look into rebasing soon.

ibotty commented 7 years ago

Don't worry, I will test later that week.