search

ibp-network / ibp-monitor

15 stars 10 forks source link

Issue with Member Level Incrementation in member.entity.js #138

Open hitchhooker opened 11 months ago

hitchhooker commented 11 months ago

It appears that there is a logic issue in the member.entity.js file, specifically at the following line: https://github.com/ibp-network/ibp-monitor/blob/59631c7ff3667f4413e14670f5df1e771b5a2476/domain/member.entity.js#L57C49

The current code seems to incorrectly increment the member level by +1, which results in monitoring for instances that are not yet running.

image

What is the reasoning here for increment? Wouldn't it be making more sense to use members.json as source truth?

hitchhooker commented 11 months ago

@pandres95 was there any reasoning for this increment if I look to fix it now over the weekend?