search

ibpsa / modelica-ibpsa-mpc

Model library for MPC
Other
8 stars 1 forks source link

added library containing Boundary_pT #2

Closed Mathadon closed 5 years ago

Mathadon commented 5 years ago

This is the first pull request for #1 . More to follow as agreed.

Mathadon commented 5 years ago

@dhblum @mwetter Please check whether you agree with the library name.

mwetter commented 5 years ago

I am not thrilled about IBPSAMPC as people are not likely to be able to understand what this means. Maybe IBPSA_MPC or IbpsaMpc would be better, although the first looks like an experimental package as was done for Modelica_Fluid before it became official.

Mathadon commented 5 years ago

@dhblum IbpsaMpc is ok for me. If you agree then I'll adjust the PR.

Mathadon commented 5 years ago

@dhblum can you check this? Thanks!

dhblum commented 5 years ago

@Mathadon, IbpsaMpc is ok for me as well. Sorry for the delay.

dhblum commented 5 years ago

@Mathadon Please also do not wait for me to merge this PR when it is edited based on the discussion above, as I will be on vacation, returning 8/19.