Nomenclature issue psychrometric utilities function

ibpsa / modelica-ibpsa

Modelica library for building and district energy systems developed within IBPSA Project 1

https://ibpsa.github.io/project1

140 stars 83 forks source link

Nomenclature issue psychrometric utilities function #1446

Closed EttoreZ closed 3 years ago

EttoreZ commented 3 years ago

I open this issue to change the description comment of the function IBPSA.Utilities.Psychrometrics.Functions.X_pW. Now is "Humidity ratio for given water vapor pressure". However from the output of the function: _algorithm x_w := 0.62198*p_w/(p - p_w); X_w := x_w/(1 + xw);

X_w is the mass fraction of water vapour in the air. Therefore the comment should be changed to "Mass fraction for given water vapor pressure" to avoid confusion.

EttoreZ commented 3 years ago

I created the branch Issue1446_PsychrometricsUtilityComment, as soon as @mwetter creates the branch I will make the pull request.

Mathadon commented 3 years ago

see https://github.com/ibpsa/modelica-ibpsa/tree/issue1446_PsychrometricsUtilityComment