ibpsa / modelica-ibpsa

Modelica library for building and district energy systems developed within IBPSA Project 1
https://ibpsa.github.io/project1
143 stars 84 forks source link

Borefield models allow inconsistent declaration for steady-state calculation of grout #1885

Closed mwetter closed 4 months ago

mwetter commented 4 months ago

The borefield models use data records for the materials and these data records have a parameter steadyState:

  parameter Boolean steadyState = (cFil < Modelica.Constants.eps or dFil < Modelica.Constants.eps)
    "Flag, if true, then material is computed using steady-state heat conduction"
    annotation(Evaluate=true);

The models also have a parameter

  // Dynamics of filling material
  parameter Boolean dynFil=true
    "Set to false to remove the dynamics of the filling material."
    annotation (Dialog(tab="Dynamics"));

Thus, one can set steadyState to any value and this won't affect dynFil, leading to potential inconsistent declarations.

This issue is to assign

  final parameter Boolean dynFil=not borFieDat.filDat.steadyState
      "Set to false to remove the dynamics of the filling material.";

and remove the parameter dynFil.