search

ibpsa / modelica-ibpsa

Modelica library for building and district energy systems developed within IBPSA Project 1
https://ibpsa.github.io/project1
142 stars 84 forks source link

Duplicate model in Psychometrics? #475

Closed Mathadon closed 7 years ago

Mathadon commented 8 years ago

It seems as if Annex60.Utilities.Psychrometrics.WetBul_pTX and Annex60.Utilities.Psychrometrics.TWetBul_TDryBulXi are more or less identical models. Can we remove either of the two? I suggest the former.

mwetter commented 8 years ago

From my point of view, Annex60.Utilities.Psychrometrics.WetBul_pTX can be deleted as all computations can also be done using Annex60.Utilities.Psychrometrics.TWetBul_TDryBulXi. The only capability that Annex60.Utilities.Psychrometrics.TWetBul_TDryBulXi adds is to output X at the wet bulb temperature, which can also be computed using X_pTphi.

@thorade , @mlauster : Is UdK Berlin and Aachen OK with removing Annex60.Utilities.Psychrometrics.WetBul_pTX? If not, then the fix of #474 also needs to be applied to this model.

mwetter commented 7 years ago

@thorade , @mlauster Can you please comment on this so we can process the issue.

mlauster commented 7 years ago

Removing should be fine for Aachen.

thorade commented 7 years ago

Removing one of the two is fine for UdK.