search

ibpsa / modelica-ibpsa

Modelica library for building and district energy systems developed within IBPSA Project 1
https://ibpsa.github.io/project1
140 stars 83 forks source link

update old notation for parameters #953

Closed mwetter closed 5 years ago

mwetter commented 6 years ago

The Airflow package has various parameters declared as

parameter Real CD=0.65 "|Orifice characteristics|Discharge coefficient";

This is an old notation and should be changed to

parameter Real CD=0.65 "Discharge coefficient"
 annotation (Dialog(group="Orifice characteristics"));
Mathadon commented 5 years ago

A search does not return any hits in annotations for '|':

> grep -R "|" ./Airflow/ ./Controls/ ./Experimental/ ./Fluid/ ./Media/ ./ThermalZones/ ./BoundaryConditions/ ./Types/
./Airflow/Multizone/BaseClasses/powerLaw.mo:  V = k sign(&Delta;p) |&Delta;p|<sup>m</sup>
./Airflow/Multizone/BaseClasses/powerLaw.mo:<i>|&Delta;p| &lt; &Delta;p<sub>t</sub></i>, where
./Airflow/Multizone/BaseClasses/powerLaw.mo:For <i>|&Delta;p| &lt; &Delta;p<sub>t</sub></i>, the equation is regularized
./Airflow/Multizone/BaseClasses/powerLawFixedM.mo:  V = k sign(&Delta;p) |&Delta;p|<sup>m</sup>
./Airflow/Multizone/BaseClasses/powerLawFixedM.mo:<i>|&Delta;p| &lt; &Delta;p<sub>t</sub></i>, where
./Airflow/Multizone/BaseClasses/powerLawFixedM.mo:For <i>|&Delta;p| &lt; &Delta;p<sub>t</sub></i>, the equation is regularized
./Fluid/BaseClasses/PartialResistance.mo:    "Turbulent flow if |m_flow| >= m_flow_turbulent";
./Fluid/FixedResistances/Validation/PlugFlowPipes/Data/BaseClasses/PipeDataBaseDefinition.mo:    "Time in s | measure 1 | measure 2 | ... | measure n |";
./Fluid/HeatExchangers/Heater_T.mo:&tau;<sub>eff</sub> = &tau; |m&#775;| &frasl; m&#775;<sub>nom</sub>
./Fluid/HeatExchangers/PrescribedOutlet.mo:&tau;<sub>eff</sub> = &tau; |m&#775;| &frasl; m&#775;<sub>nom</sub>
./Fluid/HeatExchangers/Radiators/RadiatorEN442_2.mo:     (1-f<sub>r</sub>) UA &frasl; N |T<sup>i</sup>-T<sub>a</sub>|<sup>n</sup>
./Fluid/HeatExchangers/Radiators/RadiatorEN442_2.mo:     f<sub>r</sub> UA &frasl; N |T<sup>i</sup>-T<sub>r</sub>|<sup>n</sup>
./Fluid/HeatExchangers/SensibleCooler_T.mo:&tau;<sub>eff</sub> = &tau; |m&#775;| &frasl; m&#775;<sub>nom</sub>
./Fluid/Humidifiers/SprayAirWasher_X.mo:&tau;<sub>eff</sub> = &tau; |m&#775;| &frasl; m&#775;<sub>nom</sub>
./Fluid/Humidifiers/SteamHumidifier_X.mo:&tau;<sub>eff</sub> = &tau; |m&#775;| &frasl; m&#775;<sub>nom</sub>
./Fluid/Interfaces/PrescribedOutlet.mo:&tau;<sub>eff</sub> = &tau; |m&#775;| &frasl; m&#775;<sub>nom</sub>
./Fluid/Interfaces/StaticFourPortHeatMassExchanger.mo:At <code>|m<i>N</i>_flow| &lt; deltaM<i>N</i> * m<i>N</i>_flow_nominal</code>,
./Fluid/Interfaces/StaticTwoPortHeatMassExchanger.mo:the point <code>(m_flow_nominal, dp_nominal)</code>. At <code>|m_flow| &lt; deltaM * m_flow_nominal</code>,
./Fluid/Movers/UsersGuide.mo:  W<sub>flo</sub> = | V&#775; &Delta;p |,
./Fluid/package.mo:For <i>|m&#775;| &lt; &delta;<sub>m&#775;</sub> m&#775;<sub>0</sub></i>,
./Fluid/Sensors/BaseClasses/PartialFlowSensor.mo:    "For bi-directional flow, temperature is regularized in the region |m_flow| < m_flow_small (m_flow_small > 0 required)"
./Fluid/Sensors/UsersGuide.mo:  &tau; &nbsp; dT &frasl; dt = |m&#775;| &frasl; m&#775;<sub>0</sub> &nbsp; (&theta;-T),
./Fluid/Sensors/UsersGuide.mo:<i>|m&#775;|</i> is the absolute value of the mass flow rate,
./Fluid/Sensors/UsersGuide.mo:dT &frasl; dt = |m&#775;| &frasl; m&#775;<sub>0</sub> &nbsp; (&theta;-T) &frasl; &tau; +

This can be closed as far as I am concerned.