ibpsa / project1-boptest-gym

Other
43 stars 20 forks source link

Include bounds in DiscretizedObservationWrapper #102

Closed javiarrobas closed 2 years ago

javiarrobas commented 2 years ago

Currently, the DiscretizedObservationWrapper does not include the outer space as bins. For example, if a temperature has bounds [21,24] degC and we discretize the observation space with n_bins_obs=3, the result will be an observation space defined by val_bins_obs=[21,22,23,24]. However, the temperature could go below or above the predefined bounds, in which case the returned observation will be incongruent. This issue is to add a boolean argument to the DiscretizedObservationWrapper named outs_are_bins to decide whether to include the outer observation spaces as bins or not. Following the example above, the intended behavior is the following:

Notice in both cases the observation space dimension equals n_bins_obs=3.