Multi dimensional action Issue #19

ibpsa / project1-boptest-gym

Other

43 stars 20 forks source link

Multi dimensional action Issue #19 #146

Closed IamAniket12 closed 1 month ago

IamAniket12 commented 2 months ago

This branch includes code for both Issue 19 and Issue 46.

javiarrobas commented 2 months ago

@IamAniket12 do you think you could add an example and an associated test proving the multi-dimensional action functionality?

IamAniket12 commented 2 months ago

Yes, I can definitely add an example and an associated test proving the multi-dimensional action functionality. Would you prefer it to be in a separate file? @javiarrobas

IamAniket12 commented 2 months ago

Hello @javiarrobas, added a unit test for MultiAction, please review it. Thanks

javiarrobas commented 2 months ago

Thanks a lot for the contribution @IamAniket12! I'll review it as soon as possible, hopefully by this week.

javiarrobas commented 1 month ago

@IamAniket12 I see that the only test that is not passing is the test with the vectorized environment, I'm not sure why, but that seems to be due to small numerical differences compared to references so I'm going to have a look to see how to fix that. On the other hand, I'm afraid your test is not triggered yet in GitHub Actions, I'm going configure it to be triggered.

javiarrobas commented 1 month ago

@IamAniket12 FYI, I've continued your work in this PR: https://github.com/ibpsa/project1-boptest-gym/pull/154. What I've done in summary:

Moved the functionality of your test to examples (I prefer to have it there so it serves as an example as well). See here.
Fixed your _get_indices method to account for the number of possible actions instead of the number of bins (see here. This is the reason why the vectorized environment test was not passing.
Added an example to explain functionality. See here.
Added release notes. See here.

I'm going to close this already as it is completed by the other PR.