search

ibpsa / project1-boptest-gym

Other
43 stars 20 forks source link

Origin149 fix start time examples2 #151

Closed javiarrobas closed 2 months ago

javiarrobas commented 2 months ago

Fixes #149.

javiarrobas commented 2 months ago

@IamAniket12 FYI: I'm sorry but I had to revert the edits to have just one argument for start_time in the environment. The reason is that if we remove the random_start_time_variable, whenever we restart the episode here we assign a value to start_time which is thus not None anymore. This makes further resets of the environment not to find a random start time but always start by the same one.

IamAniket12 commented 1 month ago

@javiarrobas I believe we can manage this edge case in the script without explicitly passing the random_start_time variable. If you think it's a good idea, let me know and I'll give it a try.