search

ibpsa / project1-boptest

Building Optimization Performance Tests
Other
109 stars 70 forks source link

Generate data from model #194

Open javiarrobas opened 4 years ago

javiarrobas commented 4 years ago

For test case data generation it may be easier some times to generate certain variables by simulating the model directly, or by simulating a smaller model derived from the main model. For instance, cases with complex schedules for occupancy are prone to errors if the data is generated separately from the model. I've implemented something like that for the multi zone residential hydronic test case here:

https://github.com/JavierArroyoBastida/project1-boptest/blob/issue163_testcaseMultizoneResidentialHydronic/testcases/multizone_residential_hydronic/models/generate_data.py

It could be a good idea to integrate this functionality in the Data_Generator with a new method that takes as arguments the model to be simulated and a dictionary that maps the variables of the model with the keys of the test case data variables. @dhblum what do you think?

dhblum commented 4 years ago

I think this could be a good idea and understand the issue it solves. I'm not sure at this point if it is on the critical path, but feel free to propose a PR if you have a chance. Example code is also on your fork for now too.

javiarrobas commented 4 years ago

Right now there are many pull requests in the repository so I think the best is to postpone the implementation a bit. I'll start with the PR when the other developments are settled down.