search

ibpsa / project1-boptest

Building Optimization Performance Tests
Other
109 stars 70 forks source link

Issue388 peak demand - electricity, gas, dist heat #394

Closed dhblum closed 2 years ago

dhblum commented 2 years ago

This is for #388 and implements a peak demand core KPI, for electricity only.

Still to do:

dhblum commented 2 years ago

@JavierArroyoBastida I've implemented peak demand for electricity. I plan to also implement for gas, but can you review this for now to see what you think? Gas will follow what's done here. I know in WP1.2 we talked about implementing for each energy vector, but I'm a bit unsure of the worthwhileness of this since we need to implement a new kpi for each vector and vectors outside of gas and electricity aren't really used in any of the cases yet. Could be discussed more in next WP1.2 meeting.

dhblum commented 2 years ago

@JavierArroyoBastida This is getting pretty close and I think is finished for electricity pending tests pass and after our discussion at the last WP1.2 meeting regarding using 15-min average. I plan to duplicate for gas and district heating. Let me know any further comments if you have them.

dhblum commented 2 years ago

@JavierArroyoBastida thanks for the review. I think I will replicate for Gas and District.

dhblum commented 2 years ago

@JavierArroyoBastida Gas and district heating peaks added, tests are passing. I think it's ready to merge. Take one more look with the new additions?

dhblum commented 2 years ago

Thank you @JavierArroyoBastida !!