search

ibpsa / project1-boptest

Building Optimization Performance Tests
Other
109 stars 70 forks source link

Fix issue using parser with python3 #405

Closed kbenne closed 2 years ago

kbenne commented 2 years ago

close #404

dhblum commented 2 years ago

Thanks @kbenne for the PR. Is a change not also needed at https://github.com/ibpsa/project1-boptest/blob/master/parsing/parser.py#L149 and https://github.com/ibpsa/project1-boptest/blob/master/parsing/parser.py#L163?

dhblum commented 2 years ago

@kbenne Also, please update the releasenotes.md in the backwards compatible section with a brief description and issue reference.

kbenne commented 2 years ago

Thanks @kbenne for the PR. Is a change not also needed at https://github.com/ibpsa/project1-boptest/blob/master/parsing/parser.py#L149 and https://github.com/ibpsa/project1-boptest/blob/master/parsing/parser.py#L163?

I believe, based on my scenario, the answer is no. In python 3, the result of keys() can still be iterated, it appears you just can't concatenate them with the + operator because they are now ordered lists.

kbenne commented 2 years ago

Ah. Thank you. Didn't know the convention of the release notes.

dhblum commented 2 years ago

Ok I see, great. Then this looks good. I just moved the release notes description to the top (since the top has been most recent changes). Will merge once tests pass.