Issue403 submit - Githubissues

ibpsa / project1-boptest

Building Optimization Performance Tests

Other

105 stars 69 forks source link

Issue403 submit #444

Closed dhblum closed 2 years ago

dhblum commented 2 years ago

This is for #403.

dhblum commented 2 years ago

@kbenne Can you take a look and let me know what you think? A couple specific points too:

I proposed an environment variable for the dashboard server.
Take a look at: https://github.com/ibpsa/project1-boptest/blob/issue403_submit/testcase.py#L1124. Is this the best [even good] way to handle the uid?
As noted in https://github.com/ibpsa/project1-boptest/issues/403 still need to write unit tests somehow without posting to the actual dashboard.

dhblum commented 2 years ago

@kbenne I think this is ready to merge once tests pass. Added unit test argument to /submit API which saves a payload json that is checked for unit tests instead of sending to dashboard. Unit tests also check invalid arguments and whether the time period scenario has completed or not.

Let me know any other comments if you have them.