ibpsa / project1-boptest

Building Optimization Performance Tests
Other
105 stars 69 forks source link

Issue494 baselinetesting #495

Closed terrancelu92 closed 3 months ago

terrancelu92 commented 1 year ago

The testcase driver scripts for running baseline controllers and associated results files are included.

terrancelu92 commented 1 year ago

@terrancelu92 Thank you very much for this and I really apologize for my delay in providing comments. In addition to a few general improvements and cleanup, my comments are primarily meant to improve the abstraction of the baselining process and reduce duplicated code and modules that are unnecessary. Such duplications are difficult to maintain, and difficult to understand if there are only very small changes among them.

So please see my inline comments for more details and suggestions and let me know if you have questions or other thoughts. Let me know also if these are comments you are still able to address or not. Thank you again.

@dhblum , thank you so much for the review and drafting all these comments. Yes, I will check each of these and take corresponding actions. Thanks!

dhblum commented 1 year ago

@terrancelu92 Great, thank you so much! Let me know when you've finished addressing.

terrancelu92 commented 6 months ago

@terrancelu92 Great, thank you so much! Let me know when you've finished addressing.

@dhblum Dave, I apologize for the delayed response to your comments. Your constructive feedback is greatly appreciated. Please review my inline responses and the implemented changes. If you have any further comments or suggestions, please let me know. Thank you for your patience and understanding!

terrancelu92 commented 5 months ago

Thank you @dhblum for the review! I will address these within a few days.

terrancelu92 commented 4 months ago

@dhblum , thank you for all the comments. I have addressed the following comments and also the in-line ones. Please take another review and let me know further edits if needed. Thank you!

terrancelu92 commented 3 months ago

@terrancelu92 Thank you again for addressing my comments. Can you please address just a few more I've made, in-line? We're getting close and I appreciate your effort to complete this.

@dhblum Thank you for providing detailed instructions and comments. I have incorporated the changes as per your in-line comments. Would you mind reviewing the updated version once more? Please let me know if there are any further adjustments needed. Thank you once again for your guidance!