search

ibpsa / project1-boptest

Building Optimization Performance Tests
Other
104 stars 69 forks source link

Issue540 nan kpi #543

Closed dhblum closed 1 year ago

dhblum commented 1 year ago

This is for #540. In particular, it fixes the KPI calculator so that it returns a Python None object for the computational time ratio KPI instead of NaN if the test has not been advanced yet.

Verified using Mozilla Firefox browser for testcase2 after starting test case but not advancing at all, as exampled in #540 to demonstrate error:

Screen Shot 2023-05-26 at 6 19 05 PM

Unit tests should pass.

@Enderdead can you verify I updated contributors.md properly for you? And thank you for the fix.

Enderdead commented 1 year ago

Good enough. Thank you for the reference.