Closed dhblum closed 1 year ago
In testcase.py, the self.scenario_end is used to allow submission of results to the online dashboard. This flag is set to true at https://github.com/ibpsa/project1-boptest/blob/master/testcase.py#L360 upon a user's attempt to advance a simulation past the defined scenario time period. Instead, the flag should be set to true when the user reaches the end of the scenario time period, somewhere here https://github.com/ibpsa/project1-boptest/blob/master/testcase.py#L345, and not have to try another advance call. FYI @haraldwalnum.
testcase.py
self.scenario_end
Closed by https://github.com/ibpsa/project1-boptest/pull/566.
dhblum
commented
1 year ago dhblum
commented
1 year ago
In
testcase.py, theself.scenario_endis used to allow submission of results to the online dashboard. This flag is set to true at https://github.com/ibpsa/project1-boptest/blob/master/testcase.py#L360 upon a user's attempt to advance a simulation past the defined scenario time period. Instead, the flag should be set to true when the user reaches the end of the scenario time period, somewhere here https://github.com/ibpsa/project1-boptest/blob/master/testcase.py#L345, and not have to try another advance call. FYI @haraldwalnum.