ibpsa / project1-boptest

Building Optimization Performance Tests
Other
102 stars 66 forks source link

Issue550 scenario example #553

Open kuzha opened 1 year ago

kuzha commented 1 year ago

550

@dhblum I checked the travis documentation and my understanding is that the current stable python in travis is version 3.9. So I decided to stick to version 3.9. In Python 3.9, I upgraded pip first and then upgraded the four packages numpy, pandas, matplotlib and requrests. Please double check if you get the same version as I modifed in travis. Other changes are:

dhblum commented 1 year ago

Thanks @kuzha. I'll double check the versions. But looks like in the unit tests we're getting an error: ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'OpenSSL 1.0.2g 1 Mar 2016'. See: https://github.com/urllib3/urllib3/issues/2168. I have a feeling this is related to the Ubuntu version travis is running, which looks to be Ubuntu 16 (Xenial): https://github.com/ibpsa/project1-boptest/runs/14753430755. I think it's worth updating to 18 at least if not 20 via https://docs.travis-ci.com/user/reference/linux/.

kuzha commented 1 year ago

@dhblum I googled a bit about this error and had the same conclusion as you: the error comes with the openSSL version in Ubuntu 16. I changed the default Ubuntu version in .travis.yml to 18 just to give it a try to see if the test can pass.

I have only installed Ubuntu 18 on my VM so I don't know if everything works on 20. I can give it a test locally first if you would like to update to 20.

kuzha commented 1 year ago

Some tests passed but some failed in CI. The same error occurs due to the new requests package, where more cases using np.inf have been identified. Most notably in utilities.py (see below), which has been used in many tests.

File "/home/travis/build/ibpsa/project1-boptest/testing/utilities.py", line 639, in test_set_get_scenario df = self.results_to_df(points_check, -np.inf, np.inf, self.url)

Not sure what is the best way forward. @dhblum

dhblum commented 1 year ago

Thanks @kuzha. Hm ok. This is starting to look related to https://github.com/ibpsa/project1-boptest/issues/545.