search

ibpsa / project1-boptest

Building Optimization Performance Tests
Other
102 stars 66 forks source link

Forecast horizon = 0 #554

Closed javiarrobas closed 12 months ago

javiarrobas commented 1 year ago

In this line we prevent from forecast horizons of 0. Fundamentally, that makes sense. However, the only way for a user to get to know current boundary condition data other than weather is by using the forecaster with a prediction horizon of 0. In the case of weather data, we have the weather station block, but there are others like pricing or setpoints that couldn't be retrieved for the current time otherwise. A use case can be e.g. a PI controller that reacts to deviations from a setpoint, or a reinforcement learning agent that includes current setpoints and pricing in its observation space. I therefore suggest to change the <= of that line to <.

dhblum commented 1 year ago

I agree that there is need for the use cases you mention and this seems like a simple implementation that uses existing API. Care to make a PR?

javiarrobas commented 1 year ago

Sure! sent it https://github.com/ibpsa/project1-boptest/pull/558.

dhblum commented 12 months ago

Closed by https://github.com/ibpsa/project1-boptest/pull/559.