search

ibpsa / project1-boptest

Building Optimization Performance Tests
Other
102 stars 66 forks source link

Issue577 flask float #578

Closed dhblum closed 10 months ago

dhblum commented 10 months ago

This is for #577.

dhblum commented 10 months ago

@kbenne See this PR regarding float handling related to BOPTEST-Service.

kbenne commented 10 months ago

@kbenne See this PR regarding float handling related to BOPTEST-Service.

Cool. Do you think we need updates to other reference data files in the pyfmi3 PR when this change gets merged into that PR?

dhblum commented 10 months ago

@kbenne This PR updates references results for testcase 1 and 3 due to this change. But it might be that those reference results will need to be updated again in that PR you reference (#536) with this change. I can do a check by testing PR #536 with this change.

dhblum commented 10 months ago

This will be taken care of through #536.

kbenne commented 10 months ago

Are you going to merge this into https://github.com/ibpsa/project1-boptest/tree/issue146_pyfmi3_cs now?

dhblum commented 10 months ago

There would be merge conflicts with reference unit test results, and the fix itself is one line. I was just going to implement the fix and update unit test results on the other PR, so will have that stuff pushed to that PR shortly.

dhblum commented 10 months ago

@kbenne See here, (https://github.com/ibpsa/project1-boptest/pull/536/commits/da4be6227eea189b1453d643777daa35500103a7) but I realized I need to merge latest master.