Closed EttoreZ closed 5 months ago
Thanks @EttoreZ. I just merged a pending PR that causes conflict now in the release notes for this PR. Can you resolve the conflict?
Thanks @EttoreZ. I just merged a pending PR that causes conflict now in the release notes for this PR. Can you resolve the conflict?
Sure, thank you for the heads up @dhblum.
您好,您的邮件我已收到,感谢您的来信,我会尽快给你回复。叶创
@EttoreZ Thank you for this. The implementation splits the data at year-end to 1) before the end of the year inclusive of the last data point at the end of the year (midnight), and 2) after end of the year not inclusive of the first data point at the start of the year (midnight). Please confirm this is what we agreed should be the case, rather than what is suggested in this comment. This might be the case but I can't find it in my notes. The implementation might make sense if this is what we agreed so that the forecast is more consistent for any interval through the full first year if a user only intends to simulate one year. Can you please confirm and remind me? Note I've plotted the results of unit tests below to show the performance of the implementation for forecast intervals of 1800 and 123 (as in the unit tests), compared to the reference boundary condition csv file (for an example relative humidity).
@dhblum thank you for the careful review. The implementation was indeed changed with the respect to the one mentioned in the comment for that exact reason, so that a 1 year simulation would be consistent.
@EttoreZ Ok I see thank you!
This pull request is to address issue #239, related to simulation across the year.