Closed mattrobmattrob closed 8 months ago
Thanks @mattrobmattrob for this. Have you tested on an Apple Silicon?
@EttoreZ does this work on your laptop?
Thanks @mattrobmattrob for this. Have you tested on an Apple Silicon?
Works on my M2 Pro machine.
FWIW, this stops an error about a missing x86_64 runtime file during the conda
process when not pinned on Apple Silicon machines.
@mattrobmattrob Great. Can you add to this PR:
@EttoreZ Can you just independently verify this fix works on your apple laptop?
Done. Thanks for creating that issue, @dhblum.
@dhblum I was able to reproduce the error. The fix worked and I was able to run the testcase "bestest_air" on my M1 mac.
@EttoreZ and @mattrobmattrob Thank you both! Merging once tests pass.
Pin the base Docker image to
linux/x86_64
to enable the image to be used on Apple Silicon machines easily. This can be reverted when PyFMI is distributed tolinux/arm64
(https://github.com/modelon-community/PyFMI/issues/212).Error for future reference:
The conda binary is already pinned to x86_64 so this just goes one step further with the base image:
https://github.com/ibpsa/project1-boptest/blob/358358566fc167e06c3957f5f79a6cef46812365/Dockerfile#L22
Fixes https://github.com/ibpsa/project1-boptest/issues/608.