Issue617 refactor service

ibpsa / project1-boptest

Building Optimization Performance Tests

Other

101 stars 66 forks source link

Issue617 refactor service #622

Closed dhblum closed 6 days ago

dhblum commented 4 months ago

This is a proposal for #617. So far, it:

migrates boptest-service into its own directory within the repo
removes api.py
sets up the docker-compose.yml and other Dockerfiles to work with the new directly structure.
cites the boptest-service repo license
updates unit test and example interfaces (except javascript) to pass.

See #617 for remaining todos, especially documentation/readme updates.

@kbenne @javiarrobas Care to provide initial review?

javiarrobas commented 4 months ago

Nice to see you're working on this @dhblum! Thanks a lot for the implementation and requesting review. I'll do so asap, hopefully by the end of this week.

dhblum commented 3 months ago

Thank you @javiarrobas! I'll take a look at your comments/suggestions, also with @kbenne, who plans to also see if he can replicate the migration but in a way to maintain the Service git history (in this PR I just simply moved files from that repo into this one).

dhblum commented 6 days ago

Closing, continuing in https://github.com/ibpsa/project1-boptest/pull/652.