search

ibpsa / project1

Project 1
48 stars 39 forks source link

Modelica implementation for DESTEST network #17

Open FelixBue opened 6 years ago

FelixBue commented 6 years ago

I open this issue to discuss the implementation of the network model for DESTEST,

I have started to implement the layout and made a pull request for it #15

The parameters for the pipes still need to be set. I think it would make sense to automate this based on the Pipe data.csv so we don't have to do it manually again if the loads change.

FelixBue commented 6 years ago

Also, is it normal that Dymola adds a "public" in front of every single component now?

filokot commented 6 years ago

Hi Felix,

I see you started modelling network by hand. I am actually doing the same. Unfortunately, I could not access your code. I thought that you were interested in model network by automated methods, so decided to discuss the manual part with Bram and Annelies. But since you are also interested in modelling by hand, should we have a meeting to join our effort?

Best regards, Konstantin

2018-06-13 16:50 GMT+02:00 Felix Bünning notifications@github.com:

I open this issue to discuss the implementation of the network model for DESTEST,

I have started to implement the layout and made a pull request for it #15 https://github.com/ibpsa/project1/pull/15

The parameters for the pipes still need to be set. I think it would make sense to automate this based on the Pipe data.csv so we don't have to do it manually again if the loads change.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ibpsa/project1/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/AkShYR-P6rdg4Zrql54mhf4TWi6wBjxaks5t8SavgaJpZM4UmWoG .

filokot commented 6 years ago

Yes, by default everything is public for me.

2018-06-13 16:59 GMT+02:00 Felix Bünning notifications@github.com:

Also, is it normal that Dymola adds a "public" in front of every single component now?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ibpsa/project1/issues/17#issuecomment-396968885, or mute the thread https://github.com/notifications/unsubscribe-auth/AkShYblD4iwRRju7y_m1g4MgKdfma32dks5t8SjcgaJpZM4UmWoG .