ibrahim451 / Yelp-App-

0 stars 0 forks source link

W[week-2]-Submission . Please review my app. I couldn't implement the search bar. ./cc @codepathreview #1

Open ibrahim451 opened 8 years ago

avo1 commented 8 years ago

Hi @ibrahim451 , thanks for your submission. However, the search bar was supposed to be a functioning search bar that actually displays search results in the table view. Furthermore, the search bar need to be on the navigationBar (so that user always see the searchBar). This is similar to the searchBar in the Movie assignment. I recommend you to go back and check that guide. You will need a filteredData array to save the found items, and when you reload table, you use that filteredData instead of businesses.

Please update your code within 24hr from this to receive the credit for this assignment.

Dave CodePath

ibrahim451 commented 8 years ago

Yes Sir. I updated it . I think now it works. Could you tell me if it's right now?

avo1 commented 8 years ago

:tada: It works now. I don't see you updated/pushed your latest code, but I can see that from your gif. Pls push your latest code.

:+1: Nice work! This primary challenge of this homework was to learn how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.

We have a detailed Project 3 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.

PS: Next time please create the issue with the naming convention W[week#]-Submission

Dave CodePath