ibrahimcesar / react-lite-youtube-embed

📺 ‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎< A private by default, faster and cleaner YouTube embed component for React applications />
https://www.npmjs.com/package/react-lite-youtube-embed
MIT License
269 stars 41 forks source link

Play button doesn't match official YouTube styling #108

Open jasongerbes opened 6 months ago

jasongerbes commented 6 months ago

Describe the bug The 'play button' on the embedded player doesn't match the styling of the official YouTube embedded player.

To Reproduce Steps to reproduce the behavior:

  1. Render a YouTube video using the LiteYouTubeEmbed component.

Expected behavior The 'play' button should match the official YouTube styling.

Screenshots Current styling:

Screenshot 2024-05-22 at 11 14 44 AM

Expected styling: paulirish github io_lite-youtube-embed_variants_solo html

Desktop (please complete the following information):

Additional context

The original lite-youtube-embed package uses a background-image SVG to match the play button styling to the official YouTube embedded player:

/* play button */
lite-youtube > .lty-playbtn {
    display: block;
    /* Make the button element cover the whole area for a large hover/click target… */
    width: 100%;
    height: 100%;
    /* …but visually it's still the same size */
    background: no-repeat center/68px 48px;
    /* YT's actual play button svg */
    background-image: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 68 48"><path d="M66.52 7.74c-.78-2.93-2.49-5.41-5.42-6.19C55.79.13 34 0 34 0S12.21.13 6.9 1.55c-2.93.78-4.63 3.26-5.42 6.19C.06 13.05 0 24 0 24s.06 10.95 1.48 16.26c.78 2.93 2.49 5.41 5.42 6.19C12.21 47.87 34 48 34 48s21.79-.13 27.1-1.55c2.93-.78 4.64-3.26 5.42-6.19C67.94 34.95 68 24 68 24s-.06-10.95-1.48-16.26z" fill="red"/><path d="M45 24 27 14v20" fill="white"/></svg>');
    position: absolute;
    cursor: pointer;
    z-index: 1;
    filter: grayscale(100%);
    transition: filter .1s cubic-bezier(0, 0, 0.2, 1);
    border: 0;
}
baba43 commented 3 months ago

Would love to see this by default since the current button really looks like my site is scam.