ibrahimsharaf / doc2vec

:notebook: Long(er) text representation and classification using Doc2Vec embeddings
MIT License
106 stars 43 forks source link

Convert script to OOP format #19

Closed Ayatallah closed 5 years ago

Ayatallah commented 5 years ago

Convert script to OOP format, with rebase #14

#14 Concert Script into OOP Format

  1. Replaced model.py with 4 files model.py, doc2vec_model.py, classifier_model.py, text_classifier.py
  1. Updated project structure with files increasing to enhance easily development
  2. Replaced all path used with relative paths
  3. Added mode (test/train) and filename of dataset to be used, filename of the doc2vec model to load/save trained model into, filename of classification model to load/save trained model into to the list of input provided by user when running the project form command line
  4. Removed all code parts not concerned with issue #14
  5. Rebased on master

Please review and let me know what you think!

ibrahimsharaf commented 5 years ago

Hi @Ayatallah, thanks for the PR! I really like the design 👍. I left some comments for you to progress further.

Ayatallah commented 5 years ago

@ibrahimsharaf Please review all requested changes added! Also, please note that classifier were removed from gitignore. However, since saving & loading models are removed, there is no model files available.

ibrahimsharaf commented 5 years ago

Changes look good to me, aside from simple linting errors, can you run flake8 . in your project directory, to show you pep8 linting/styling errors, then add it in a final commit?

Ayatallah commented 5 years ago

@ibrahimsharaf Please check now!

ibrahimsharaf commented 5 years ago

Merged! thanks @Ayatallah 🏆