search

ibrahimsn98 / SmoothBottomBar

A lightweight Android material bottom navigation bar library
MIT License
1.97k stars 255 forks source link

cornerRadius adds radius to all four corners #85

Closed gargVader closed 3 years ago

gargVader commented 3 years ago

Intended UI is to only have topLeft and topRight radius.

Faulty: Screenshot_1624467998

Correct: Screenshot_1624474548

amiyo-biswas-mongia commented 3 years ago

Have you add top radius ?

n-droidev commented 2 years ago

I have this issue too.. How to fix this ? It applies cornerRadius to all corners when I select any corner. Corner selection doesnt work.

brookmg commented 2 years ago

What version are you using?

n-droidev commented 2 years ago

Latest.. 1.7.8 I forked library and when giving corners it works correctly.. But when I add library to my project it doesnt work and SmoothBottomBar.kt codes are different than actual codes in library.. There is slight differences.. Maybe you didnt change version code at the latest build.. Turkce konusursan daha iyi anlarim kardesim Sunday, 30 January 2022, 01:14AM +04:00 from Brook Mezgebu @.*** :

What version are you using? — Reply to this email directly, view it on GitHub , or unsubscribe . Triage notifications on the go with GitHub Mobile for iOS or Android . You are receiving this because you commented. Message ID: @ github . com>

brookmg commented 2 years ago

Ya unfortunately fix hasn't been released yet. The latest (1.7.8) doesn't contain #94. @ibrahimsn98 will hopefully release a newer version soon but until then forking the lib and directly adding it should work.

n-droidev commented 2 years ago

I cant directly add it.. It makes me crazy.. Gives error.. And I added it via my fork but didnt work again.. I will try to fix it  by myself.. Do you know why it works correctly with your library's sample app?

Sent from Mail.ru app for Android Sunday, 30 January 2022, 01:46AM +04:00 from Brook Mezgebu @.*** :

Ya unfortunately fix hasn't been released yet. The latest (1.7.8) doesn't contain #94 . @ibrahimsn98 will hopefully release a newer version soon but until then forking the lib and directly adding it should work. — Reply to this email directly, view it on GitHub , or unsubscribe . Triage notifications on the go with GitHub Mobile for iOS or Android . You are receiving this because you commented. Message ID: @ github . com>

brookmg commented 2 years ago

The sample app directly imports the module from local directory as they are under a same gradle configuration.

Try to use this 

dependencies {   implementation 'com.github.ibrahimsn98:SmoothBottomBar:-SNAPSHOT'  }

when you import it into your project instead of specifying the version code. This will pull the latest commit from the master branch which in this case contains the fix.

n-droidev commented 2 years ago

I fixed it via changing build.gradle version code to 2.. And released 1.7.9.. It worked now.. Weird implementation 'com.github.n-droidev:SmoothBottomBar:1.7.9'

n-droidev commented 2 years ago

I created pull request

brookmg commented 2 years ago

The sample app directly imports the module from local directory as they are under a same gradle configuration.

Try to use this 

dependencies {     implementation 'com.github.ibrahimsn98:SmoothBottomBar:-SNAPSHOT'  }

when you import it into your project instead of specifying the version code. This will pull the latest commit from the master branch which in this case contains the fix.

This would've been a better solution for you instead of releasing your own. No need for a new PR, ibrahim will release a new version soon anyway.