search

ibrierley / flutter_map_dragmarker

A drag marker for flutter_map
BSD 3-Clause "New" or "Revised" License
54 stars 37 forks source link

Bump dependency to flutter_map 1.0.0 #14

Closed pablojimpas closed 2 years ago

pablojimpas commented 2 years ago

Fixes breaking changes introduced since the last major flutter_map release. Primarily instances of Stream used in the plugin API now have become Stream.

While I was here I've also added an analysis_options.yaml file using flutter_lints and fix some static analysis errors found, hopefully I didn't break something. I've also improved a little bit the formatting and wording of the REAME, mostly cosmetic changes.

To release a new version bump it in the pubspec.yaml and update the changelog when it's ready.

ibrierley commented 2 years ago

Actually, I guess we should also bump the version of this package...

pablojimpas commented 2 years ago

Removing flutter: uses-material-design: true from the main pubspec breaks the icons from working which is curious, as I thought they'd just be needed in the example pubspec.

Sorry, I removed that while cleaning up stuff from the pubspec.yaml

I'd also rather the pubspec.lock not be included unless there's a compelling reason. The prevailing wisdom is not to include this for packages, but include for applications, to allow a wider scope of versions to be used.

I've ignored it in the main library package, I'll do that on the example as well in case that is a problem.

pablojimpas commented 2 years ago

I think this is still just waiting for the material design to be back in the main pubspec, but otherwise all looks good.

Ready now! Sorry again...

ibrierley commented 2 years ago

lgtm thanks!