Use flutter_map_dragmarker package, add native example projects

ibrierley / flutter_map_line_editor

A basic line/poly editor that works with flutter_map and dragmarkers.

MIT License

44 stars 25 forks source link

Use flutter_map_dragmarker package, add native example projects #36

Closed josxha closed 1 year ago

josxha commented 1 year ago

This pull request...

removes dragmarkers.dart and uses the functionality from the flutter_map_dragmarker package (currently set to https://github.com/josxha/flutter_map_dragmarker. Use the pub.dev version when it's released.)
adds native integrations to make it easier to run it the example project.

pablojimpas commented 1 year ago

Hi @josxha, thanks for taking the time to do this! I was preparing a patch with something like this myself, but I'm glad that yours is ready now.

I will test everything and get back to you with my feedback.

josxha commented 1 year ago

Thanks @pablojimpas! I was only able to test on android and web myself so I'm interested if other platforms work as well. (:

pablojimpas commented 1 year ago

Hey @josxha, is this PR ready for another full review, or should it be synced with the latest flutter_map_dragmarker?

josxha commented 1 year ago

@pablojimpas It was using dragmarkers from git. I changed it to pub.dev in https://github.com/ibrierley/flutter_map_line_editor/pull/36/commits/28592d0b086dea4d38b677a7c2db2835e9b64cc4. Yep, ready to test now. (:

pablojimpas commented 1 year ago

The example app works fine on every platform that I've tested (Linux, Android, Web). The code looks good to me as well. I think this is ready to be merged and released on pub.dev if @ibrierley it's okay.

ibrierley commented 1 year ago

Great stuff, tests well for me. Thanks for all the work on this!

ibrierley commented 1 year ago

Is now on pub.dev