ibroadfo / ember-cli-deploy-firebase

an ember-cli-deploy plugin to deploy to firebase hosting
MIT License
6 stars 13 forks source link

Needs updating to Ember 3.x, ember-cli-babel 6.x #5

Open buzzware opened 6 years ago

buzzware commented 6 years ago

This was holding my Ember 3.1 app back to ember-cli-babel 5.x. When I removed ember-cli-deploy-firebase-pack to use @econlab/ember-cli-deploy-firebase I got ember-cli-babel 6.x, but then I got a build error :

$ ember deploy production cleaning up... Deploying [🚀 ] 100% [plugin: firebase -> upload]

Should we use "firebase deploy" instead ?

alexparker commented 6 years ago

@buzzware did you figure out a work-around or solution? I have run into this now too, and was curious

buzzware commented 6 years ago

@alexparker No, I just use "ember build -e production" then "firebase deploy" and not this or ember deploy at all, which is why I posted https://github.com/ibroadfo/ember-cli-deploy-firebase/issues/6

mileszim commented 6 years ago

@buzzware @alexparker I'd be happy to do a full ember-cli upgrade and fix errors for the one at econlab tomorrow or so, I'll keep you posted.