search

ibrod83 / nodejs-file-downloader

129 stars 23 forks source link

fix useSynchronousMode bug #61

Open alen256 opened 10 months ago

alen256 commented 10 months ago

fix a bug when useSynchronousMode = true, download two same name file at same time, finally only have one file

ibrod83 commented 8 months ago

Hey, thank you for the PR. I don't think this is a good solution to the problem, because it hardcodes ".download" into the function, and also violates its responsibility. Why do you need the sync mode? I originally made this option for some debugging needs i had back then