search

ibrod83 / nodejs-web-scraper

81 stars 26 forks source link

Add page address argument to `CollectContent`s config handler for `getAllElements()` #15

Closed LeWestopher closed 3 years ago

LeWestopher commented 3 years ago

Currently, the getAllElements() method provided by the CollectContent configuration does not receive a page address argument as part of the call. I have added this argument to the call so that it can be consumed by the end user when doing complex scraping strategies. I don't foresee this being a breaking change for your API, as it's just an extra arg in the args list but if you see an issue with it I'm happy to rewrite it however necessary!

The docs in the readme.md have also been updated as part of this PR to reflect the change.

ibrod83 commented 3 years ago

Hey, thank you. I'll test the program with the change later on.