search

ibrokemypie / mastalab

GNU General Public License v3.0
5 stars 0 forks source link

fix mentions #1

Open todo[bot] opened 5 years ago

todo[bot] commented 5 years ago

https://github.com/ibrokemypie/mastalab/blob/95c3733e8ccfeba3b1c899c9a15b2cbdd3fd0b69/app/src/main/java/fr/gouv/etalab/mastodon/client/API.java#L3042-L3047

This issue was generated by todo based on a TODO comment in 95c3733e8ccfeba3b1c899c9a15b2cbdd3fd0b69. It's been assigned to @ibrokemypie because they committed the code.
ibrokemypie commented 5 years ago

16

ghost commented 5 years ago

The way it works is fully different. I currently removed it from the "follow Misskey instances". I will investigate a proper way to do that with the existing code.

ibrokemypie commented 5 years ago

i can get the mentions as shown in https://github.com/ibrokemypie/mastalab/commit/4ef9b549fe91b345f190eb1fd72eadebc2aac239 however that does work, cant use getAccount in the static context

i dont really know how to work around this

ibrokemypie commented 5 years ago

to summarize, the way mentions work in misskey is there is a mentions array that hold just user ids, regardless of whether they are local or remote users, and a remote users array which contains objects with usernames and hosts of remote users, in the same order as the mentions (ids) array i assume

this second remote mentions array doesnt exist if they are local mentions, plus it doesnt include much info (it seems pretty pointless tbh) it is much better to get the user data of each mentioned user by their id in the mentions array and just ignore the second one