search

ibrokemypie / mastalab

GNU General Public License v3.0
5 stars 0 forks source link

support reactions #25

Open todo[bot] opened 5 years ago

todo[bot] commented 5 years ago

https://github.com/ibrokemypie/mastalab/blob/7fb749085a36b2a5b06d7e0f0a81057a29c703d9/app/src/main/java/fr/gouv/etalab/mastodon/client/API.java#L3219-L3224

This issue was generated by todo based on a TODO comment in 7fb749085a36b2a5b06d7e0f0a81057a29c703d9. It's been assigned to @ibrokemypie because they committed the code.
ibrokemypie commented 5 years ago

from #6

react/fav api hasnt been touched yet would also require rework of ui

ghost commented 5 years ago

I noticed it was possible to get favourites from [reactions:{like:x}], I guess it should be the same for renotes

ibrokemypie commented 5 years ago

misskey treats favourites and reactions as seperate actions, however when conveying this to other backends it simply treats reactions as favourites since they do not support reacts so for the moment, favouriting works fine, the favourite button sets a favourite, or removes it this is certainly enough for general use, though it does cut out one of the larger misskey features

ideally we have a seperate react button that brings up a grid of the different reactions

ghost commented 5 years ago

ideally we have a seperate react button that brings up a grid of the different reactions

Yes, it is what should be done. I am still discovering Misskey but it should fit as much as possible.