search

ibs-lab / cedalion

fNIRS analysis toolbox
MIT License
21 stars 8 forks source link

changes to scalp_plot and bug fixes in motion_correct #27

Closed lauracarlton closed 2 months ago

lauracarlton commented 2 months ago
  1. add 10-5 EEG info to data folder so that it is accessible by scalp_plot
  2. bug fix in output dimensions of splineSG and PCArecurse so they match the input dimensions
  3. fixed output warning about downcasting xarray to numpy array
dboas commented 2 months ago

@lauracarlton I wonder if you could do a pull request for the motion correction stuff separate from the others. I am comfortable reviewing and approving the motion correction stuff, but not the changes you made to the plot and ICA files.

lauracarlton commented 2 months ago

I will close this pull request and split it into two.

lauracarlton commented 2 months ago

@lauracarlton I wonder if you could do a pull request for the motion correction stuff separate from the others. I am comfortable reviewing and approving the motion correction stuff, but not the changes you made to the plot and ICA files.

I am trying to figure out how to do this - it seems like the pull request includes all commits made to the branch. I can try splitting these changes into two different branches and then creating two different pull requests from there?

dboas commented 2 months ago

That is probably the right way to do it… two separate branches. Sorry for the trouble.

From: Laura Carlton @.> Date: Friday, August 16, 2024 at 1:33 PM To: ibs-lab/cedalion @.> Cc: Boas, David @.>, Review requested @.> Subject: Re: [ibs-lab/cedalion] changes to scalp_plot and bug fixes in motion_correct (PR #27)

@lauracarltonhttps://github.com/lauracarlton I wonder if you could do a pull request for the motion correction stuff separate from the others. I am comfortable reviewing and approving the motion correction stuff, but not the changes you made to the plot and ICA files.

I am trying to figure out how to do this - it seems like the pull request includes all commits made to the branch. I can try splitting these changes into two different branches and then creating two different pull requests from there?

— Reply to this email directly, view it on GitHubhttps://github.com/ibs-lab/cedalion/pull/27#issuecomment-2293894486, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHFCP5COCO6564FG4CNXB3TZRYZWJAVCNFSM6AAAAABMQZM75CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTHA4TINBYGY. You are receiving this because your review was requested.Message ID: @.***>