search

ibsh / is_KeyFinder

Musical key detection software for digital DJs, for Mac OSX and Windows, released under GPL v3
www.ibrahimshaath.co.uk/keyfinder
324 stars 52 forks source link

Menu organisation breaks after translation #77

Closed pyntel closed 11 years ago

pyntel commented 11 years ago

I couldn't even find Preferences at first, because it's no longer in the same place as before.

Also the Mac OSX systemwide preference pane shortcut no longer works, is this a bug, by-effect, or a conscious design choice?

ibsh commented 11 years ago

Hey. The localisation is automatic based on system wide settings. I suppose I could add the option to change it but it seems rather counterintuitive. Is there something you dislike about the Dutch localisation specifically? Anything you could fix in the translation?

As for the Preferences item moving in the menu, I think that must be a bug related to the localisation. Can you please attach a screenshot of where it is now (so I can see both the location and any associated keystroke)? That would be great.

Thanks Ibrahim

ibsh commented 11 years ago

The standard Preferences shortcut is now fixed, though it may still appear in the wrong part of the menu.

pyntel commented 11 years ago

Sorry it took a while to reply, had a very busy schedule last few days.

In general I never really like apps to automatically pick a localisation without giving me a choice in the matter. Although Dutch is my native language, I have always used English OS installations for Windows, Mac, Linux, etc and this does include software. I don't know what it is exactly, but for example I just can't work in a Dutch version of Office for example. And because everything is set to the English language, it kind of irks me that one application suddenly would show up in Dutch.

pyntel commented 11 years ago

Actually, no change at all for me there as you can see from attached screenshot:

screen shot 2013-07-15 at 13 38 17

Edit: the shortcut itself DOES work in the app, it just isn't shown in the localised user interface like command N or W are.

ibsh commented 11 years ago

I accept that it's a pain that Qt translates apps based on the locale rather than the system language on Mac; I'll look into that and see if there's a way to base it on the language instead. I will split that out into another issue.

I'm glad the shortcut works but its visual disassociation and misplacement must be a mistake on my part. I'll investigate, thanks.

pyntel commented 11 years ago

No thanks at all Ibsh, glad to help out.

Have you started using Qt as a GUI Library only since version 1.17+ then? I reckon 1.18 was an unreleased test version for this?

ibsh commented 11 years ago

No, it's been Qt since before release. The Dutch translation is the only new bit.

ibsh commented 11 years ago

This is fixed in source. Will be released in 1.22.